-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use "import type" in the Typescript SDK #623
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Looks like this has been around since TS 3.8 - but I do have a question around what versions of typescript we're committed to supporting in this SDK? Also, I'd consider switching to a |
CI is wonky - it's reporting the "skipped" runs (from the cla-bot applying "cla: yes" tag) instead of the real runs: you can see both on the checks tab (CI did pass). Need to figure that out |
Good question about supported TS versions. I'd say since we're just now approaching GA, TS 4.x is our minimum |
We can consider it a "fix" although nothing was broken. It just wasn't optimal. |
This comment has been minimized.
This comment has been minimized.
Test Results 7 files 73 suites 3m 57s ⏱️ Results for commit c7b5bf8. |
@joeldodge79 I agree; the minimum version we support in the GA should be the current version at that time. That's TS 4.2 as of today, with TS 4.3 scheduled for May 25. At minimum, TS 4.1 has some extremely powerful new features that I would not want to be without in the long term. |
We currently build codegen with TS 4.2.2, so I'm personally fine with saying 4.2 and above |
Updated the code generator and the TS SDK to use
import type
where appropriate