Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce size of apix bundle #676

Merged
merged 1 commit into from
May 11, 2021

Conversation

bryans99
Copy link
Collaborator

  1. all package builds now generate es modules.
  2. functions from lodash now imported in the format import pick from 'lodash/pick'

1. all package builds now generate es modules.
2. functions from lodash now imported in the format `import pick from 'lodash/pick'`
@bryans99 bryans99 requested review from jkaster and noahamac May 11, 2021 17:06
@google-cla google-cla bot added the cla: yes label May 11, 2021
@github-actions
Copy link
Contributor

Codegen Tests

  1 files    6 suites   21s ⏱️
58 tests 46 ✔️ 12 💤 0 ❌

Results for commit e04ed7b.

@github-actions
Copy link
Contributor

Typescript Tests

    7 files    73 suites   4m 11s ⏱️
153 tests 153 ✔️ 0 💤 0 ❌
535 runs  535 ✔️ 0 💤 0 ❌

Results for commit e04ed7b.

Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice it's a consistent pattern easy to learn/remember.

@bryans99 bryans99 merged commit 0d74f6a into main May 11, 2021
@bryans99 bryans99 deleted the brynryans/apix-bundle-size-reduction branch May 11, 2021 21:16
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants