Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: paging results for the Typescript SDK #698

Merged
merged 27 commits into from
Jun 30, 2021
Merged

feat: paging results for the Typescript SDK #698

merged 27 commits into from
Jun 30, 2021

Commits on May 20, 2021

  1. WIP TS SDK pagination implementation 

    Very broken right now
    @jkaster
    jkaster committed May 20, 2021
    Configuration menu
    Copy the full SHA
    06de862 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. Merge branch 'main' into jk/pagination

    @jkaster
    jkaster committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    f399f10 View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2021

  1. linkHeaderParser() works 

    WIP on `Paginator` and tests
    @jkaster
    jkaster committed Jun 5, 2021
    Configuration menu
    Copy the full SHA
    062309a View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. feat: paged SDK results via Link header 

    Implemented for the TS SDK first

- includes unit tests
    @jkaster
    jkaster committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    a51e9ca View commit details
    Browse the repository at this point in the history

  2. corrected comment example

    @jkaster
    jkaster committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    d1da812 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. improved paging function names, added comments

    @jkaster
    jkaster committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    7fc8f3b View commit details
    Browse the repository at this point in the history

  2. Added pagination.md and cleaned up some code

    @jkaster
    jkaster committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    9ae801c View commit details
    Browse the repository at this point in the history

  3. doc tweak

    @jkaster
    jkaster committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    56fe422 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. improved node transport error handling 

    things were broken after pagination refactoring. Now they're fixed and improved.
    @jkaster
    jkaster committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    24aa480 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Merge remote-tracking branch 'origin/main' into jk/pagination

    @jkaster
    jkaster committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    e2abd40 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Merge branch 'main' into jk/pagination

    @jkaster
    jkaster authored Jun 18, 2021
    Configuration menu
    Copy the full SHA
    129e3bb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'jk/pagination' of github.com:looker-open-source/sdk-cod… 

    …egen into jk/pagination
    @jkaster
    jkaster committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    f20c7af View commit details
    Browse the repository at this point in the history

  3. Improved pagination.md

    @jkaster
    jkaster committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    1b679fc View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. Functional tests for SDK pagination work 

    Tests are currently commented out until a Looker release with pagination headers is available
    @jkaster
    jkaster committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    8bfb0e2 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2021

  1. Merge branch 'main' into jk/pagination

    @jkaster
    jkaster authored Jun 25, 2021
    Configuration menu
    Copy the full SHA
    7766a3b View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Merge branch 'main' into jk/pagination

    @jkaster
    jkaster authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    7ecf22a View commit details
    Browse the repository at this point in the history

  2. Updated pagination notes

    @jkaster
    jkaster committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    6ed5636 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/jk/pagination' into jk/pagination

    @jkaster
    jkaster committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    37f430e View commit details
    Browse the repository at this point in the history

  4. Updated pagination notes

    @jkaster
    jkaster committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    a38b963 View commit details
    Browse the repository at this point in the history

  5. Skip pagination tests until headers are available

    @jkaster
    jkaster committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    b608855 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into jk/pagination

    @jkaster
    jkaster authored Jun 28, 2021
    Configuration menu
    Copy the full SHA
    8b16379 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Change "pagination" to "paging"

    @jkaster
    jkaster committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    f12337e View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/jk/pagination' into jk/pagination

    @jkaster
    jkaster committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    ec60987 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2021

  1. Merge remote-tracking branch 'origin/main' into jk/pagination

    @jkaster
    jkaster committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    5035439 View commit details
    Browse the repository at this point in the history

  2. Address PR feedback

    @jkaster
    jkaster committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    d37062f View commit details
    Browse the repository at this point in the history

  3. PR feedback for unit test clarifications 

    Also added functional test to verify pageAll works with non-paging endpoints
    @jkaster
    jkaster committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    ca6618a View commit details
    Browse the repository at this point in the history

  4. Skip functional tests relying on unreleased features

    @jkaster
    jkaster committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    2a84405 View commit details
    Browse the repository at this point in the history