-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: publish prep for api-explorer, code-editor, run-it #721
Conversation
@@ -11,7 +11,7 @@ | |||
], | |||
"author": "Looker", | |||
"license": "MIT", | |||
"private": true, | |||
"private": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noahamac release-please currently has code-editor
set to release as 0.1.3
https://github.com/looker-open-source/sdk-codegen/pull/716/files#diff-1e654be0dda2a3ab3237f96fcb7251ecd7367635523a76e1c1302b979354abbcR3
let me know if you want it to bump to 1.0.0
instead and I can tweak the config (and deal with some manual changes required when a dep moves from "pre-1.0.0" to "post-1.0.0")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joeldodge79 code-editor can be bumped to 1.0.0 or left at 0.1.3... Whatever is easier for you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending the semver change for code-editor
This comment has been minimized.
This comment has been minimized.
APIX Tests 1 files 72 suites 2m 25s ⏱️ Results for commit c23dca6. |
No description provided.