Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish prep for api-explorer, code-editor, run-it #721

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

joeldodge79
Copy link
Contributor

No description provided.

@@ -11,7 +11,7 @@
],
"author": "Looker",
"license": "MIT",
"private": true,
"private": false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noahamac release-please currently has code-editor set to release as 0.1.3 https://github.com/looker-open-source/sdk-codegen/pull/716/files#diff-1e654be0dda2a3ab3237f96fcb7251ecd7367635523a76e1c1302b979354abbcR3

let me know if you want it to bump to 1.0.0 instead and I can tweak the config (and deal with some manual changes required when a dep moves from "pre-1.0.0" to "post-1.0.0")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeldodge79 code-editor can be bumped to 1.0.0 or left at 0.1.3... Whatever is easier for you

@github-actions
Copy link
Contributor

APIX Tests

    1 files  ±0    72 suites  ±0   2m 10s ⏱️ -14s
279 tests ±0  267 ✔️ ±0  12 💤 ±0  0 ❌ ±0 
298 runs  ±0  286 ✔️ ±0  12 💤 ±0  0 ❌ ±0 

Results for commit 8232c61. ± Comparison against base commit 28a1bbe.

Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the semver change for code-editor

@joeldodge79 joeldodge79 merged commit e9518ea into main Jun 29, 2021
@joeldodge79 joeldodge79 deleted the new-public-ts-packages branch June 29, 2021 23:26
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

APIX Tests

    1 files    72 suites   2m 25s ⏱️
279 tests 267 ✔️ 12 💤 0 ❌
298 runs  286 ✔️ 12 💤 0 ❌

Results for commit c23dca6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants