Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extension-api-explorer build #740

Merged
merged 1 commit into from
Jul 7, 2021
Merged

fix: extension-api-explorer build #740

merged 1 commit into from
Jul 7, 2021

Conversation

bryans99
Copy link
Collaborator

@bryans99 bryans99 commented Jul 7, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Jul 7, 2021
jkaster
jkaster approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Dunno how I missed this. I thought I tested apix as well

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2021

APIX Tests

    1 files    72 suites   2m 3s ⏱️
279 tests 267 ✔️ 12 💤 0 ❌
298 runs  286 ✔️ 12 💤 0 ❌

Results for commit b25d39b.

@bryans99
Copy link
Collaborator Author

bryans99 commented Jul 7, 2021

Thanks. Dunno how I missed this. I thought I tested apix as well

It was the bundle that failed. We should probably add that to CI even if its throwaway. I'll look into it as part of the standalone build for Noah

@bryans99 bryans99 merged commit 1697883 into main Jul 7, 2021
@bryans99 bryans99 deleted the brynryans/fix-apix-ext-build branch July 7, 2021 21:13
@github-actions

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaster jkaster jkaster approved these changes

@josephaxisa josephaxisa Awaiting requested review from josephaxisa

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryans99 @jkaster