Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes a golang leak on every REST request #779

Merged
merged 4 commits into from
Aug 6, 2021

Conversation

panoskoug
Copy link
Collaborator

per Do documentation: "If the returned error is nil, the Response will contain a non-nil Body which the user is expected to close."

per Do documentation: "If the returned error is nil, the Response will contain a non-nil Body which the user is expected to close."
@google-cla google-cla bot added the cla: yes label Aug 4, 2021
@panoskoug panoskoug changed the title fixes a leak on every REST request fix: fixes a golang leak on every REST request Aug 4, 2021
Copy link
Contributor

@joeldodge79 joeldodge79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks for the fix!

@joeldodge79 joeldodge79 merged commit 4932baa into looker-open-source:main Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants