fix: placate TypeScript 4.4 #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
AprilArcus
force-pushed
the
april/typescript-4.4
branch
2 times, most recently
from
f24e118
to
6733f40
Compare
AprilArcus
force-pushed
the
april/typescript-4.4
branch
from
6733f40
to
1d39ec0
Compare
|
@joeldodge79 adding you because of the version bump in the rtl package.json .. that may be the domain of release-please? |
joeldodge79
previously requested changes
Aug 31, 2021
Co-authored-by: Joel Dodge <joeldodge@google.com>
joeldodge79
approved these changes
Sep 1, 2021
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript 4.4 assigns errors the type
unknownby default in catch clauses. This PR supplies the necessary assertions to safely extract themessagefield inbrowserTransport.ts, and rethrows the error if it fails to meet these expectations.