fix: logic for 2D JSON data detection #840
Conversation
APIX Tests 1 files 77 suites 2m 57s ⏱️ Results for commit bde6a98. |
| * @param json to analyze | ||
| */ | ||
| const getTypes = (json: any) => { | ||
| const types = [new Set<ItemType>(), new Set<ItemType>()] |
There was a problem hiding this comment.
can json be a string, number, boolean or date?
There was a problem hiding this comment.
the value passed in that we expect to be JSON could be any type
| const data = json2Csv(content) | ||
| const showGrid = isColumnar(data.data) | ||
| const json = JSON.stringify(JSON.parse(response.body), null, 2) | ||
| const parsed = JSON.parse(response.body) |
There was a problem hiding this comment.
What if body is not JSON? parse will fail
There was a problem hiding this comment.
the pickResponseHandler decides what renderer to use. If we're in this function it has to be a json:
APIX Tests 1 files 77 suites 2m 12s ⏱️ Results for commit 6ccb3d8. |
APIX Tests 1 files ±0 77 suites ±0 2m 10s ⏱️ -40s Results for commit dbbf919. ± Comparison against base commit eb1731f. This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both. |
This comment has been minimized.
This comment has been minimized.
Only truly 2D JSON data should have a grid. This fixes erroneous DataGrid rendering