Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: optimize scripts for parallel startup of Looker docker image #881

Merged
merged 8 commits into from
Oct 29, 2021
Merged

fix: optimize scripts for parallel startup of Looker docker image #881

merged 8 commits into from
Oct 29, 2021

Conversation

drstrangelooker
Copy link
Collaborator

I move the setup for getting and starting the Docker image to the start of the process. Then I let the other setup proceed.
Finally, just before the actual tests, I run the wait_for_looker script to check that Looker has started successfully.

@google-cla google-cla bot added the cla: yes label Oct 29, 2021
@github-actions
Copy link
Contributor

Codegen Tests

  1 files    6 suites   20s ⏱️
58 tests 46 ✔️ 12 💤 0 ❌

Results for commit 43e76ad.

@github-actions
Copy link
Contributor

Python Tests

    6 files      6 suites   3s ⏱️
117 tests 117 ✔️ 0 💤 0 ❌
696 runs  696 ✔️ 0 💤 0 ❌

Results for commit 43e76ad.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    75 suites   3m 58s ⏱️
167 tests 163 ✔️   4 💤 0 ❌
555 runs  543 ✔️ 12 💤 0 ❌

Results for commit 43e76ad.

@github-actions
Copy link
Contributor

Python Tests

    6 files      6 suites   2s ⏱️
117 tests 117 ✔️ 0 💤 0 ❌
696 runs  696 ✔️ 0 💤 0 ❌

Results for commit 43e76ad.

@github-actions
Copy link
Contributor

Python Tests

    6 files      6 suites   2s ⏱️
117 tests 117 ✔️ 0 💤 0 ❌
696 runs  696 ✔️ 0 💤 0 ❌

Results for commit e5b1573.

@github-actions
Copy link
Contributor

Python Tests

    6 files      6 suites   2s ⏱️
117 tests 117 ✔️ 0 💤 0 ❌
696 runs  696 ✔️ 0 💤 0 ❌

Results for commit 39595c3.

@github-actions
Copy link
Contributor

Python Tests

    9 files      9 suites   2m 7s ⏱️
140 tests 140 ✔️ 0 💤 0 ❌
765 runs  765 ✔️ 0 💤 0 ❌

Results for commit b4e0790.

@github-actions
Copy link
Contributor

Python Tests

    9 files      9 suites   2m 9s ⏱️
140 tests 140 ✔️ 0 💤 0 ❌
765 runs  765 ✔️ 0 💤 0 ❌

Results for commit 9e289b5.

@github-actions
Copy link
Contributor

Codegen Tests

  1 files    6 suites   26s ⏱️
58 tests 46 ✔️ 12 💤 0 ❌

Results for commit 9e289b5.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    75 suites   3m 46s ⏱️
167 tests 163 ✔️   4 💤 0 ❌
555 runs  543 ✔️ 12 💤 0 ❌

Results for commit 9e289b5.

jkaster
jkaster approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One question about moving one of the steps

.github/workflows/codegen-ci.yml Show resolved Hide resolved
@drstrangelooker drstrangelooker merged commit 5624c72 into main Oct 29, 2021
@drstrangelooker drstrangelooker deleted the drstrangelove/optimize-CI branch October 29, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaster jkaster jkaster approved these changes

@joeldodge79 joeldodge79 Awaiting requested review from joeldodge79

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drstrangelooker @jkaster