chore: export reused api explorer functionality from root index.ts #890
Conversation
APIX Tests0 files 0 suites 0s ⏱️ Results for commit 7e41ec7. |
APIX Tests 1 files 77 suites 2m 59s ⏱️ Results for commit 05d633d. |
There was a problem hiding this comment.
Looking good so far. I'll hold final approval for when it's out of draft mode.
- Running
yarn test:apixI get a warning about an improper teardown, butyarn test:apix --detectOpenHandlesdoesn't show any warnings or details at all - Running
yarn dev:apixI get:
Uncaught TypeError: Failed to construct 'URL': Invalid base URL
at App.tsx:43
packages/api-explorer/src/index.ts
Outdated
| export * from './ApiExplorer' | ||
| export { Loader } from './components' | ||
| export { store } from './state' |
There was a problem hiding this comment.
mix of * and named exports?
There was a problem hiding this comment.
I'll switch to named exports from 'ApiExplorer' for consistency
| @@ -32,10 +32,8 @@ import type { ExtensionContextData } from '@looker/extension-sdk-react' | |||
| import { ExtensionContext } from '@looker/extension-sdk-react' | |||
| import type { SpecItem, SpecList } from '@looker/sdk-codegen' | |||
| import { getSpecsFromVersions } from '@looker/sdk-codegen' | |||
| import ApiExplorer from '@looker/api-explorer/src/ApiExplorer' | |||
| import { Loader } from '@looker/api-explorer/src/components' | |||
| import { ApiExplorer, store, Loader } from '@looker/api-explorer' | |||
|
@jkaster |
APIX Tests 1 files 77 suites 2m 49s ⏱️ Results for commit 6b6ded5. |
packages/api-explorer/src/index.ts
Outdated
| SOFTWARE. | ||
|
|
||
| */ | ||
| export { ApiExplorer } from './ApiExplorer' |
There was a problem hiding this comment.
Any compile issues with this? We've had to use export * elsewhere. Are there any other exports? if no consider switching to export *
APIX Tests 1 files 77 suites 2m 52s ⏱️ Results for commit b1f2933. |
APIX Tests 1 files 77 suites 3m 18s ⏱️ Results for commit 151cb79. |
This comment has been minimized.
This comment has been minimized.
No description provided.