feat: looker resources index #931
Conversation
fabio-looker
changed the title
bin/looker-resources-index/README.md
Outdated
|
|
||
| The main location that the data is maintained is in `src/resource-data/resources.ts` | ||
|
|
||
| The main output of these scripts is a JSON file in `../../docs/resources` intended to be checked in to git and consumed via CDN. (However, you could conceivably also consume the typescript exports from this folder) |
There was a problem hiding this comment.
(However, you could conceivably also consume the typescript exports from this folder) -> If you need the types and LocaleStrings, you need to import the typescript exports from this folder, bin/looker-resources-index
There was a problem hiding this comment.
LGTM outside of minor Readme change. Good stuff, dig the analyze and build functionality and the additional fields like language. Thanks for making the resources listing much more robust and detailed. :D
I'll setup a few tasks to: 1) Add json to CDN 2) Integrate into hackathon 3) Integrate into devportal.
|
Also will add one more task for CI to auto build json on merge. |
…n-source/sdk-codegen into fabble/looker-resources-index
fabio-looker
dismissed stale reviews from jeremytchang and jkaster
via
f64a6c4
|
@jeremytchang Updated the line in the readme that you commented on, so I need to request a re-approval! Thanks 😄 |
This PR adds the "Looker resources index"
As its readme explains, this folder contains data (in code) about Looker-related resources, and scripts to maintain and repackage that data for publication.
The resource data is based off of (and enhanced from) the data in https://github.com/looker-open-source/sdk-codegen/blob/main/packages/hackathon/src/scenes/ResourceScene/resource_data.ts
However, this change now decouples the data from the hackathon app (e.g. so it can also be used in the developer portal), and allows it to be published to a web CDN as JSON, rather than only imported as a TS dependency.