Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update readme to link to update_prod_branches_to_main.py #971

Conversation

eric-lyons
Copy link
Contributor

👋👋 Thank you for contributing to Looker sdk-codegen (⚡️🍣)

📺 Watch a quick video on how to you make your pull requests fast and easy for you and your reviewer(s):
https://threadit.app/thread/k45nyrqugoinw6xub9vf/message/fl8m57exhqg4r0a4hg01eebn

  • 👆 Make sure your pull request title follows Pull Request Title Guidelines from our Contribution guide
  • 👉 Don't forget to replace these instructions with your ✨awesome✨ description of what this change actually does. Additionally, it's great to include context on how it works and why the change was needed.
  • 👇 Edit "Developer Checklist" to reflect items relevant to this PR (and try to make sure to check everything off before asking for review)

Developer Checklist ℹ️

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

eric-lyons and others added 9 commits July 22, 2021 09:51
Many people have come on chat about creating schedules with the sdk and I just wanted to create a barebones example, so we can direct them to a public example.
Updated readme to point at simple_schedule_plan example
Update readme to link to new example of adding users to a group from a CSV.
@drstrangelooker drstrangelooker changed the base branch from main to eric-lyons/add_update_prod_branch_to_main February 14, 2022 22:07
@drstrangelooker
Copy link
Collaborator

I'm merging this with a branch on our repo, then from their we can merge to main.

@drstrangelooker drstrangelooker merged commit 42cb618 into looker-open-source:eric-lyons/add_update_prod_branch_to_main Feb 14, 2022
@drstrangelooker
Copy link
Collaborator

#986

drstrangelooker added a commit that referenced this pull request Feb 15, 2022
…986)

* Create simple_schedule_plan.py

Many people have come on chat about creating schedules with the sdk and I just wanted to create a barebones example, so we can direct them to a public example.

* Update README.md

Updated readme to point at simple_schedule_plan example

* Update README.md

Update readme to link to new example of adding users to a group from a CSV.

* updated readme to point at script which updates prod branches touse main rather than master

Co-authored-by: Joel Dodge <joeldodge@google.com>
Co-authored-by: Dr. Strangelove <drstrangelove@google.com>

Co-authored-by: Eric Lyons <53839634+eric-lyons@users.noreply.github.com>
Co-authored-by: Joel Dodge <joeldodge@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants