Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: runtime error for API Explorer #973

Merged
merged 1 commit into from
Feb 8, 2022
Merged

fix: runtime error for API Explorer #973

merged 1 commit into from
Feb 8, 2022

Conversation

jkaster
Copy link
Contributor

@jkaster jkaster commented Feb 7, 2022

item instanceof Method

checks started failing for some obscure reason, so a new isMethod() check is now used

yarn test:apix && yarn test:apix-e2e

passes again. End-to-end tests needed to be updated for the (Beta) string also

```ts
item instanceof Method
```

checks started failing for some obscure reason, so a new `isMethod()` check is now used
Copy link
Collaborator

@bryans99 bryans99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version issue?

yarn.lock Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

APIX Tests

    1 files    80 suites   2m 52s ⏱️
322 tests 309 ✔️ 13 💤 0 ❌
338 runs  325 ✔️ 13 💤 0 ❌

Results for commit 93cff06.

Copy link
Collaborator

@bryans99 bryans99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkaster jkaster merged commit 4823fcb into main Feb 8, 2022
@jkaster jkaster deleted the jk/fix_apix branch February 8, 2022 00:15
@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants