Fetch some jmx stats #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,12 +28,12 @@ INSTALL | |||
| Copy the statsd library from the .m2 folder to cassandra/lib. | |||
| Add the following to your cassandra startup script: | |||
|
|
|||
| Copy the agent-1.1.jar to a new directory cassandra/plugins | |||
| Copy the agent-1.2.jar to a new directory cassandra/plugins | |||
|
|
|||
| Change cassandra startup to add this agent. This can be done in | |||
| a stock install by adding the following to /etc/default/cassandra: | |||
There was a problem hiding this comment.
You are THE expert here.
But, when I ran the tests yesterday, I added the following line conf/cassandra-env.sh. There is a lot of option tweaking there - including JMX settings.
There was a problem hiding this comment.
Agreed. The reason for putting it somewhere else is that chef manages the cassandra-env.sh file. More specifically, it's the community cookbook that manages that file, so adding that line in there was much more challenging. JMX settings are all controlled by the community cookbook.
Also, I phrased the README to say that it "can be done" this way but doesn't mean there aren't other ways to do it :)
|
👍 @rkuris I just have a few minor comments/questions/notes. |
rkuris
force-pushed
the
fetch-some-jmx-stats
branch
3 times, most recently
from
1b8a819 to
57ef2b7
Compare
This is a pretty big refactor. There are now three sources of data for logging to statsd: the JVM (now in JavaVMGenerator), yammer metrics (now in YammerMetricsGenerator) and JMX (see CassandraJMXGenerator). Unfortunately, the CassandraJMXGenerator has to know some of the internals of how Cassandra reports JMX. It's coded to be somewhat bulletproof, such that missing JMX variables won't stop the other found ones from being reported. Right now, we fetch: gossip.score.<IP>, which help decide who is closer/faster for queries gossip.severity, which indicates how busy this node is self-reporting to others cfstats.<keyspace>.<columnfamily>.ReadCount cfstats.<keyspace>.<columnfamily>.WriteCount cfstats.<keyspace>.<columnfamily>.RecentReadLatencyMicros cfstats.<keyspace>.<columnfamily>.RecentWriteLatencyMicros cfstats.<keyspace>.<columnfamily>.TombstonesPerSlice cfstats.<keyspace>.<columnfamily>.estimatedKeys The last one is great for monitoring general trends, but of course don't rely on that number to be very accurate. Also supported is the currently-experimental PHI reporter, in PHI.<IP>, coming to a Cassandra cluster near you soon.
rkuris
force-pushed
the
fetch-some-jmx-stats
branch
from
57ef2b7 to
8459f0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@maheshkelkar can you take a look at this before I merge it? In particular, take a look at CassandraJMXGenerator.