Iamroles account #64
Merged
Iamroles account #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add ability to pass search filters down to application searching in front50.
…apshots in target/managed account (spinnaker#1846)
…1869) I figured we'd add a quick one-line how-to for getting gradle to build your intellij project too.
…pinnaker#1876) * feat(provider/kubernetes): Infer relationships from ownerReference * feat(provider/kubernetes): Cache ancillary resources
A number of k8s resources use a spec.template to deploy a managed resource. These need to be annotated by Spinnaker as well.
* allows search providers to specify an exclusion list for filter keys to optionally be removed before executing a search.
…es when deleting a security group (spinnaker#1894)
This also refactors all the tests involving google API metrics.
…t the right endpoint (spinnaker#1888)
adds the `catalogFile` option to the Docker Registry provider. This is
an attempt to make it easier to use registries that don't support
`v2/_catalog` (which happens to be a lot). This file can be managed by
an external process. Each caching cycle, Clouddriver reads this file to
determine the list of repositories it should cache tags for.
the format of the `configFile` is:
```
{
"repositories":[
"library/nginx",
"library/busybox"
]
}
```
Bug introduced in `f70d6ea`. I updated the constructor to include `catalogFile` but didn't update the constructor for those using `password` and `passwordFile` configurations. This fixes that potential issue.
…vider get the right endpoint (spinnaker#1888)" (spinnaker#1904) This reverts commit 828fbb7.
…pinnaker#1907) For consistency with naming & other resources.
…1997) - updated code that allows ingress from elb group to app security group
…2015) * fix(provider/gae): Delete gcs target directory in deploy. * fix(storage): Change the storage account endpoint to '/storage'.
The kubernetes api allows dots in secret names: https://github.com/kubernetes/kubernetes/blob/e5ac41331119bb8c67004b8efaa0c3d942b31d3a/pkg/api/validation/validation.go#L160-L162 https://github.com/kubernetes/kubernetes/blob/8d7d7a5e0d4d7e75f5a860574346944b8cc0fc43/staging/src/k8s.io/apimachinery/pkg/util/validation/validation.go#L126-L142 https://github.com/kubernetes/kubernetes/blob/e5ac41331119bb8c67004b8efaa0c3d942b31d3a/pkg/api/validation/validation.go#L1488 This allows dots in the secretName field of volume source definitions.
…er#2019) This is an optimization for fetching target server groups by `CURRENT`, `PREVIOUS`, `OLDEST` and `FAIL`. For these strategies, the unexpanded server group is sufficient to narrow down to a match. Once a match is found, _only_ that server group will be expanded. This only works for cluster providers that support loading both expanded and unexpanded server groups (ie. aws). The behavior for other providers should be unchanged.
- fixed NPE due to missing credentials in security group description request
… security groups (aka ingress resources) (spinnaker#2000) (spinnaker#2005)
…#2025) - Updated to only auto create <appname>-elb group for new ELBs
…spinnaker#2026) Expectation is that a `subnetType` will still be provided and that `subnetIds` will be a subnet of those valid for `subnetType`. When explicit subnet ids are provided (or inherited), the newly created server group will be tagged with: `SPINNAKER_SUBNET_ID_OVERRIDE`: `"comma-separated list of subnet ids"`
The instanceId was intended to be the value in dataCenterInfo.metadata but due to some Jackson behaviour the top level instanceId from the discovery registration was written over the dataCenterInfo.metadata during deserialization. This changes to explicitly handle the top level instanceId value in the JsonCreator factory method to prevent the unhandled property behaviour from kicking in.
|
LGTM +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dkirillov nevermind the commit history :)