Merge in #94
Merged
Merge in #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed NPE due to missing credentials in security group description request
… security groups (aka ingress resources) (spinnaker#2000) (spinnaker#2005)
…#2025) - Updated to only auto create <appname>-elb group for new ELBs
…spinnaker#2026) Expectation is that a `subnetType` will still be provided and that `subnetIds` will be a subnet of those valid for `subnetType`. When explicit subnet ids are provided (or inherited), the newly created server group will be tagged with: `SPINNAKER_SUBNET_ID_OVERRIDE`: `"comma-separated list of subnet ids"`
The instanceId was intended to be the value in dataCenterInfo.metadata but due to some Jackson behaviour the top level instanceId from the discovery registration was written over the dataCenterInfo.metadata during deserialization. This changes to explicitly handle the top level instanceId value in the JsonCreator factory method to prevent the unhandled property behaviour from kicking in.
…ns (spinnaker#2024) In what appears to be the absence of another v1 resize validator, KubernetesResizeServerGroupValidator was being picked up which wasn't correctly declaring its support for v2 only.
…le (spinnaker#2036) api client lib.
spinnaker#2021) * feat(provider/kubernetes): support delete and update strategies operation for new controllers. * feat(provider/kubernetes): added partition and podManagementPolicy fields. * feat(provider/kubernetes): added deletion parameters. * feat(provider/kubernetes): fixed format problem and cleanup texts.
…ker#2045) The AWS `createTags` API requires at least one tag to be provided. Rather than error out, let's just skip the update entirely and return success.
…spinnaker#2258) Also log an error when edda retries have been exhausted.
… with the same port mappings. (spinnaker#2257)
…innaker#2266) This should provide coverage for all currently available instance types. Will look for better ways to manage this moving forward.
…aker#2272) update AllowedAccountsValidator to use permissions config in addition to requiredGroupMemberships
…naker#2259) Do not attempt artifact replacement if no target was found. Reading a non-existing path can return an empty ArrayNode object, in which case we should not attempt any replacement. Add checks for bound artifacts in artifact replacement tests.
…e bugs. (spinnaker#2276) feat(provider/kubernetes): split out required & optional artifacts (spinnaker#2273) fix(provider/docker): update bearer_token to access_token (spinnaker#2274)
…#2280) The `startJob` method submits your request to a threadpool, which it immediately starts polling. This isn't useful, and limits the number of jobs that can be started to the number of threads supported by your scheduler. As a result, submitting a lot of jobs at once causes (needlessly) a lot of these jobs to timeout. There is still a `sleep(500)` which doesn't seem to add anything in the function, but didn't feel confident removing since other spots in clouddriver make use of it.
…aker#2279) Set the default namespace according to the `kubectl` rules defined in https://github.com/kubernetes/kubernetes/blob/bd4d511a40e142ee65edff3b286e57de502aa790/pkg/kubectl/cmd/util/factory_client_access.go#L127 In short, the default namespace is set in this way: - If `/var/run/secrets/kubernetes.io/serviceaccount/namespace` exists, assume we are running in a Kubernetes container, and set the default namespace to the contents of this file. - Set the default namespace to the namespace of current `kubectl` config context, if it exists. `kubectl config view` is used to get this namespace, which takes care of the complicated merges and overrides. - Otherwise, set the default namespace to "default". This fixes the issue of manifests without a namespace specification being deployed in the namespace of clouddriver when Spinnaker has been deployed in Kubernetes. Previously manifests without a namespace were assumed to belong to the "default" namespace, but clouddriver would deploy them in the "spinnaker" namespace, where it is deployed by default by Halyard. Deploying such manifests would cause Spinnaker to get stuck waiting for a deployment to show up in the "default" namespace, since clouddriver would instead have created a deployment in the "spinnaker" namespace.
…er#2264) * Added EcsLoadbalancerCacheClient with a cache model and test. * Object mapper configuration moved to declaration line. * Clean up.
…er#2265) * Added EcsTargetGroupCacheClient with a model and tests. * Changes based on feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.