Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zstd #36

Merged
merged 1 commit into from
Mar 14, 2021
Merged

add zstd #36

merged 1 commit into from
Mar 14, 2021

Conversation

ksurl
Copy link
Contributor

@ksurl ksurl commented Jan 27, 2021

add support for zstd compression

@ksurl
Copy link
Contributor Author

ksurl commented Jan 27, 2021

running tar manually in the container works but it fails when calling it from the docker cli. any ideas?

manual command:

tar -C /volume -I zstd -cf /backup/test.zstd ./

via container with local test image:
docker run --rm -v test:/volume:ro volume-backup:test backup -c zstd - > /folder/backup.zstd

via image would just print the usage text and exit

update: ignore the error. I was still using your image in my script, not the test image. it works fine. should be good to merge

@loomchild
Copy link
Owner

loomchild commented Jan 27, 2021

Thanks a lot for your contribution - I will test it and merge it in a few days (focusing now on FOSDEM / https://fosdem.sojourner.rocks/ 😅)

@ksurl
Copy link
Contributor Author

ksurl commented Mar 5, 2021

any update on this?

@loomchild
Copy link
Owner

Not yet.

@loomchild
Copy link
Owner

Hi, it seems to work OK. I will merge it. (and add -zstd to the usage message). Thanks for your help and sorry for delay.

@loomchild loomchild merged commit 0cec0d7 into loomchild:master Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants