Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency path-to-regexp to v6.3.0 [security] #10646

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 10, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
path-to-regexp 6.2.2 -> 6.3.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-45296

Impact

A bad regular expression is generated any time you have two parameters within a single segment, separated by something that is not a period (.). For example, /:a-:b.

Patches

For users of 0.1, upgrade to 0.1.10. All other users should upgrade to 8.0.0.

These versions add backtrack protection when a custom regex pattern is not provided:

They do not protect against vulnerable user supplied capture groups. Protecting against explicit user patterns is out of scope for old versions and not considered a vulnerability.

Version 7.1.0 can enable strict: true and get an error when the regular expression might be bad.

Version 8.0.0 removes the features that can cause a ReDoS.

Workarounds

All versions can be patched by providing a custom regular expression for parameters after the first in a single segment. As long as the custom regular expression does not match the text before the parameter, you will be safe. For example, change /:a-:b to /:a-:b([^-/]+).

If paths cannot be rewritten and versions cannot be upgraded, another alternative is to limit the URL length. For example, halving the attack string improves performance by 4x faster.

Details

Using /:a-:b will produce the regular expression /^\/([^\/]+?)-([^\/]+?)\/?$/. This can be exploited by a path such as /a${'-a'.repeat(8_000)}/a. OWASP has a good example of why this occurs, but the TL;DR is the /a at the end ensures this route would never match but due to naive backtracking it will still attempt every combination of the :a-:b on the repeated 8,000 -a.

Because JavaScript is single threaded and regex matching runs on the main thread, poor performance will block the event loop and can lead to a DoS. In local benchmarks, exploiting the unsafe regex will result in performance that is over 1000x worse than the safe regex. In a more realistic environment using Express v4 and 10 concurrent connections, this translated to average latency of ~600ms vs 1ms.

References


Release Notes

pillarjs/path-to-regexp (path-to-regexp)

v6.3.0: Fix backtracking in 6.x

Compare Source

Fixed


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added dependencies Pull requests that update a dependency file SECURITY labels Sep 10, 2024
@renovate renovate bot requested a review from a team September 10, 2024 00:03
@renovate renovate bot changed the title chore: update dependency path-to-regexp to v8 [security] chore: update dependency path-to-regexp to v8 [security] - autoclosed Sep 10, 2024
@renovate renovate bot closed this Sep 10, 2024
@renovate renovate bot deleted the renovate/npm-path-to-regexp-vulnerability branch September 10, 2024 04:57
@renovate renovate bot changed the title chore: update dependency path-to-regexp to v8 [security] - autoclosed chore: update dependency path-to-regexp to v8 [security] Sep 10, 2024
@renovate renovate bot reopened this Sep 10, 2024
@renovate renovate bot restored the renovate/npm-path-to-regexp-vulnerability branch September 10, 2024 15:31
@renovate renovate bot force-pushed the renovate/npm-path-to-regexp-vulnerability branch from d32ecd3 to f06a4c7 Compare September 10, 2024 15:32
@renovate renovate bot changed the title chore: update dependency path-to-regexp to v8 [security] chore: update dependency path-to-regexp to v8 [security] - autoclosed Sep 11, 2024
@renovate renovate bot closed this Sep 11, 2024
@renovate renovate bot deleted the renovate/npm-path-to-regexp-vulnerability branch September 11, 2024 17:24
@renovate renovate bot changed the title chore: update dependency path-to-regexp to v8 [security] - autoclosed chore: update dependency path-to-regexp to v8 [security] Sep 11, 2024
@renovate renovate bot reopened this Sep 11, 2024
@renovate renovate bot restored the renovate/npm-path-to-regexp-vulnerability branch September 11, 2024 20:25
@renovate renovate bot force-pushed the renovate/npm-path-to-regexp-vulnerability branch from f06a4c7 to def57a4 Compare September 11, 2024 20:26
@renovate renovate bot changed the title chore: update dependency path-to-regexp to v8 [security] chore: update dependency path-to-regexp to v8 [security] - autoclosed Sep 12, 2024
@renovate renovate bot closed this Sep 12, 2024
@renovate renovate bot deleted the renovate/npm-path-to-regexp-vulnerability branch September 12, 2024 17:19
@renovate renovate bot changed the title chore: update dependency path-to-regexp to v8 [security] - autoclosed chore: update dependency path-to-regexp to v8 [security] Sep 12, 2024
@renovate renovate bot restored the renovate/npm-path-to-regexp-vulnerability branch September 12, 2024 18:39
@renovate renovate bot reopened this Sep 12, 2024
@renovate renovate bot changed the title chore: update dependency path-to-regexp to v8 [security] chore: update dependency path-to-regexp to v6.3.0 [security] Sep 12, 2024
@renovate renovate bot force-pushed the renovate/npm-path-to-regexp-vulnerability branch 5 times, most recently from 9cf5ac3 to a624e6f Compare September 16, 2024 13:56
@renovate renovate bot force-pushed the renovate/npm-path-to-regexp-vulnerability branch from a624e6f to 06e4e19 Compare September 24, 2024 13:53
@renovate renovate bot force-pushed the renovate/npm-path-to-regexp-vulnerability branch from 06e4e19 to 4d1d6f3 Compare September 24, 2024 14:03
@renovate renovate bot force-pushed the renovate/npm-path-to-regexp-vulnerability branch 4 times, most recently from a04d385 to db844bf Compare October 8, 2024 00:27
@renovate renovate bot force-pushed the renovate/npm-path-to-regexp-vulnerability branch 3 times, most recently from e7cfb5b to 8731c6a Compare October 17, 2024 03:23
@renovate renovate bot force-pushed the renovate/npm-path-to-regexp-vulnerability branch 8 times, most recently from c82526d to 0a5c253 Compare October 24, 2024 02:43
@achrinza achrinza marked this pull request as ready for review October 24, 2024 02:46
@renovate renovate bot force-pushed the renovate/npm-path-to-regexp-vulnerability branch 3 times, most recently from d797ab3 to 78c2416 Compare October 24, 2024 23:40
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot force-pushed the renovate/npm-path-to-regexp-vulnerability branch from 78c2416 to db7e264 Compare October 25, 2024 14:49
@achrinza achrinza merged commit a7ee522 into master Oct 26, 2024
12 of 13 checks passed
@achrinza achrinza deleted the renovate/npm-path-to-regexp-vulnerability branch October 26, 2024 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file SECURITY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant