-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependency path-to-regexp to v6.3.0 [security] #10646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate
bot
added
dependencies
Pull requests that update a dependency file
SECURITY
labels
Sep 10, 2024
renovate
bot
changed the title
chore: update dependency path-to-regexp to v8 [security]
chore: update dependency path-to-regexp to v8 [security] - autoclosed
Sep 10, 2024
renovate
bot
changed the title
chore: update dependency path-to-regexp to v8 [security] - autoclosed
chore: update dependency path-to-regexp to v8 [security]
Sep 10, 2024
renovate
bot
force-pushed
the
renovate/npm-path-to-regexp-vulnerability
branch
from
September 10, 2024 15:32
d32ecd3
to
f06a4c7
Compare
renovate
bot
changed the title
chore: update dependency path-to-regexp to v8 [security]
chore: update dependency path-to-regexp to v8 [security] - autoclosed
Sep 11, 2024
renovate
bot
changed the title
chore: update dependency path-to-regexp to v8 [security] - autoclosed
chore: update dependency path-to-regexp to v8 [security]
Sep 11, 2024
renovate
bot
force-pushed
the
renovate/npm-path-to-regexp-vulnerability
branch
from
September 11, 2024 20:26
f06a4c7
to
def57a4
Compare
renovate
bot
changed the title
chore: update dependency path-to-regexp to v8 [security]
chore: update dependency path-to-regexp to v8 [security] - autoclosed
Sep 12, 2024
renovate
bot
changed the title
chore: update dependency path-to-regexp to v8 [security] - autoclosed
chore: update dependency path-to-regexp to v8 [security]
Sep 12, 2024
renovate
bot
changed the title
chore: update dependency path-to-regexp to v8 [security]
chore: update dependency path-to-regexp to v6.3.0 [security]
Sep 12, 2024
renovate
bot
force-pushed
the
renovate/npm-path-to-regexp-vulnerability
branch
5 times, most recently
from
September 16, 2024 13:56
9cf5ac3
to
a624e6f
Compare
renovate
bot
force-pushed
the
renovate/npm-path-to-regexp-vulnerability
branch
from
September 24, 2024 13:53
a624e6f
to
06e4e19
Compare
renovate
bot
force-pushed
the
renovate/npm-path-to-regexp-vulnerability
branch
from
September 24, 2024 14:03
06e4e19
to
4d1d6f3
Compare
renovate
bot
force-pushed
the
renovate/npm-path-to-regexp-vulnerability
branch
4 times, most recently
from
October 8, 2024 00:27
a04d385
to
db844bf
Compare
renovate
bot
force-pushed
the
renovate/npm-path-to-regexp-vulnerability
branch
3 times, most recently
from
October 17, 2024 03:23
e7cfb5b
to
8731c6a
Compare
renovate
bot
force-pushed
the
renovate/npm-path-to-regexp-vulnerability
branch
8 times, most recently
from
October 24, 2024 02:43
c82526d
to
0a5c253
Compare
renovate
bot
force-pushed
the
renovate/npm-path-to-regexp-vulnerability
branch
3 times, most recently
from
October 24, 2024 23:40
d797ab3
to
78c2416
Compare
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate
bot
force-pushed
the
renovate/npm-path-to-regexp-vulnerability
branch
from
October 25, 2024 14:49
78c2416
to
db7e264
Compare
achrinza
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
6.2.2
->6.3.0
GitHub Vulnerability Alerts
CVE-2024-45296
Impact
A bad regular expression is generated any time you have two parameters within a single segment, separated by something that is not a period (
.
). For example,/:a-:b
.Patches
For users of 0.1, upgrade to
0.1.10
. All other users should upgrade to8.0.0
.These versions add backtrack protection when a custom regex pattern is not provided:
They do not protect against vulnerable user supplied capture groups. Protecting against explicit user patterns is out of scope for old versions and not considered a vulnerability.
Version 7.1.0 can enable
strict: true
and get an error when the regular expression might be bad.Version 8.0.0 removes the features that can cause a ReDoS.
Workarounds
All versions can be patched by providing a custom regular expression for parameters after the first in a single segment. As long as the custom regular expression does not match the text before the parameter, you will be safe. For example, change
/:a-:b
to/:a-:b([^-/]+)
.If paths cannot be rewritten and versions cannot be upgraded, another alternative is to limit the URL length. For example, halving the attack string improves performance by 4x faster.
Details
Using
/:a-:b
will produce the regular expression/^\/([^\/]+?)-([^\/]+?)\/?$/
. This can be exploited by a path such as/a${'-a'.repeat(8_000)}/a
. OWASP has a good example of why this occurs, but the TL;DR is the/a
at the end ensures this route would never match but due to naive backtracking it will still attempt every combination of the:a-:b
on the repeated 8,000-a
.Because JavaScript is single threaded and regex matching runs on the main thread, poor performance will block the event loop and can lead to a DoS. In local benchmarks, exploiting the unsafe regex will result in performance that is over 1000x worse than the safe regex. In a more realistic environment using Express v4 and 10 concurrent connections, this translated to average latency of ~600ms vs 1ms.
References
Release Notes
pillarjs/path-to-regexp (path-to-regexp)
v6.3.0
: Fix backtracking in 6.xCompare Source
Fixed
f1253b4
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.