Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow rest-server to be mounted on a path to express #2387

Merged
merged 1 commit into from
Feb 15, 2019
Merged

feat: allow rest-server to be mounted on a path to express #2387

merged 1 commit into from
Feb 15, 2019

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Feb 14, 2019 •
edited
Loading

See #2306 (comment)

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@raymondfeng raymondfeng changed the title Allow rest-server to be mounted on a path to express feat: allow rest-server to be mounted on a path to express Feb 14, 2019
@raymondfeng raymondfeng mentioned this pull request Feb 14, 2019
Closed
7 tasks
bajtos
bajtos reviewed Feb 14, 2019
View reviewed changes
greenkeeper.json Outdated Show resolved Hide resolved
@bajtos bajtos added feature REST Issues related to @loopback/rest package and REST transport in general labels Feb 14, 2019
@raymondfeng
Copy link
Contributor Author

@bajtos PTAL.

@raymondfeng raymondfeng merged commit de8f626 into master Feb 15, 2019
@raymondfeng raymondfeng deleted the allow-express-baseurl branch February 15, 2019 16:09
This was referenced Feb 21, 2019
Merged
Closed
raymondfeng added a commit that referenced this pull request Feb 26, 2019
@raymondfeng
fix(rest-explorer): allow explorer for a rest app to be mounted to ex…
6f12f7b 
…press

This is a follow-up to #2387
@raymondfeng raymondfeng mentioned this pull request Feb 26, 2019
Merged
7 tasks
raymondfeng added a commit that referenced this pull request Feb 27, 2019
@raymondfeng
fix(rest-explorer): allow explorer for a rest app to be mounted to ex…
5d2db07 
…press

This is a follow-up to #2387
automateddecision pushed a commit to automateddecision/joblink-loopback-explorer that referenced this pull request Apr 9, 2020
@raymondfeng
fix(rest-explorer): allow explorer for a rest app to be mounted to ex…
fdd578d 
…press

This is a follow-up to loopbackio/loopback-next#2387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

Assignees
No one assigned
Labels
feature REST Issues related to @loopback/rest package and REST transport in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raymondfeng @bajtos