refactor(http-server): remove "request" module from tests #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
added
refactor
REST
raymondfeng
reviewed
Apr 2, 2019
| uri: server.url, | ||
| }), | ||
| ).to.be.rejectedWith(/ECONNREFUSED/); | ||
| await expect(httpGetAsync(server.url)).to.be.rejectedWith(/ECONNREFUSED/); |
There was a problem hiding this comment.
Does supertest hide ECONNREFUSED too?
There was a problem hiding this comment.
I don't know 🤷♂️ . httpGetAsync is using Node.js core API, it's the simplest possible solution. That's why I prefer it over supertest or request.
raymondfeng
approved these changes
Apr 2, 2019
nabdelgadir
approved these changes
Apr 2, 2019
bajtos
force-pushed
the
refactor/http-server-tests
branch
from
c267a46
to
2a86c2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2672.
This pull request is removing
requestfrom dev-dependencies of@loopback/http-server. The only test using that module is reworked to usehttpGetAsyncfrom Node.js core instead.Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated