refactor: use top-level .gitignore & .travis.yml #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up based on a review comment here: #858 (comment) 36 This removes package level .gitignore and .travis.yml files in favour of top-level files.
virkt25
requested review from
bajtos,
kjdelisle,
raymondfeng and
shimks
as code owners
raymondfeng
approved these changes
Jan 17, 2018
shimks
reviewed
Jan 17, 2018
| @@ -1,3 +0,0 @@ | |||
| coverage | |||
| node_modules | |||
There was a problem hiding this comment.
do we need a line for cli/node_modules in the top-level as well?
There was a problem hiding this comment.
I don't think so. node_modules in top level .gitignore should have it covered.
There was a problem hiding this comment.
top level has a node_modules folder which works for all sub-directories. sandbox was specific to cli so it was marked as such.
There was a problem hiding this comment.
oops didn't see your response there ... but what @raymondfeng said basically.
b-admike
approved these changes
Jan 17, 2018
virkt25
added a commit
that referenced
this pull request
Jan 18, 2018
Follow up based on a review comment here: #858 (comment) This removes package level .gitignore and .travis.yml files in favour of top-level files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up based on a review comment here:
#858 (comment)
This removes package level .gitignore and .travis.yml files in favour
of top-level files.
Checklist
npm testpasses on your machinepackages/cliwere updatedpackages/example-*were updated