feat: Micro optimizations to improve performance.

loophp · Dec 20, 2021 · b898474 · b898474
1 parent a806dcc
commit b898474
Showing 1 changed file with 6 additions and 13 deletions.
diff --git a/src/SimpleCachingIteratorAggregate.php b/src/SimpleCachingIteratorAggregate.php
@@ -22,17 +22,13 @@
  */
 final class SimpleCachingIteratorAggregate implements IteratorAggregate
 {
-    private const IS_IDLE = true;
-
-    private const IS_ONGOING = false;
+    private bool $hasStarted = false;
 
     /**
      * @var CachingIterator<int|string, T>
      */
     private CachingIterator $iterator;
 
-    private bool $status = self::IS_IDLE;
-
     /**
      * @param Iterator<int|string, T> $iterator
      */
@@ -49,9 +45,8 @@ public function __construct(Iterator $iterator)
      */
     public function getIterator(): Traversable
     {
-        if (self::IS_IDLE === $this->status) {
-            $this->status = self::IS_ONGOING;
-
+        if (false === $this->hasStarted) {
+            $this->hasStarted = true;
             $this->iterator->next();
 
             for (; $this->iterator->valid(); $this->iterator->next()) {
@@ -61,12 +56,10 @@ public function getIterator(): Traversable
             return $this;
         }
 
-        if (self::IS_ONGOING === $this->status) {
-            $this->iterator->next();
+        $this->iterator->next();
 
-            for (; $this->iterator->valid(); $this->iterator->next()) {
-                $this->iterator->current();
-            }
+        for (; $this->iterator->valid(); $this->iterator->next()) {
+            $this->iterator->current();
         }
 
         return yield from $this->iterator->getCache();