Refactor spain country handler #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphp
force-pushed
the
refactor-spain-country-handler
branch
from
3bfd34b to
ce6ce6d
Compare
|
Thank you for your work and patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
It was technically impossible to restore the previous PR because the name of the branch was
master.We have no other solution than re-create another branch. While doing that I accidentally merged it.
Had to force push on
masterbranch to restore the state before the erroneous commit and create the new PR. Hope this is a lesson learned for you, never work on the master branch if you want to contribute to a project :) Create a new branch!