Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deal with the new 0.27.0 platform pattern #25

Merged
merged 6 commits into from
Jan 27, 2023

Conversation

looztra
Copy link
Owner

@looztra looztra commented Jan 27, 2023

  • fix: update platform pattern
  • fix: deal with version
  • fix: deal with version

@looztra looztra force-pushed the feat/6/update-platform-pattern branch from 6f11e65 to 02bb93f Compare January 27, 2023 09:04
@github-actions
Copy link

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

In bin/install line 299:
install_tool "$ASDF_INSTALL_TYPE" "$ASDF_INSTALL_VERSION" "$ASDF_INSTALL_PATH" "$_tmp_download_dir" "$g_binary_name" "$g_binary_altname" "$g_downloaded_file_is_not_an_archive"
^---------------^ SC2154: g_binary_altname is referenced but not assigned.

For more information:
https://www.shellcheck.net/wiki/SC2154 -- g_binary_altname is referenced bu...
shfmt erros
No errors or shfmt is disabled

@github-actions
Copy link

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

In bin/install line 299:
install_tool "$ASDF_INSTALL_TYPE" "$ASDF_INSTALL_VERSION" "$ASDF_INSTALL_PATH" "$_tmp_download_dir" "$g_binary_name" "$g_binary_altname" "$g_downloaded_file_is_not_an_archive"
^---------------^ SC2154: g_binary_altname is referenced but not assigned.

For more information:
https://www.shellcheck.net/wiki/SC2154 -- g_binary_altname is referenced bu...
shfmt erros
No errors or shfmt is disabled

@looztra looztra force-pushed the feat/6/update-platform-pattern branch from 9b6a8a3 to 299a85d Compare January 27, 2023 09:08
@github-actions
Copy link

sh-checker report

To get the full details, please check in the job output.

shellcheck errors

'shellcheck ' returned error 1 finding the following syntactical issues:

----------

In bin/install line 299:
readonly _tmp_download_dir="$(mktemp -d -t 'asdf_XXXXXXXX')"
         ^---------------^ SC2155 (warning): Declare and assign separately to avoid masking return values.

For more information:
  https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to ...
----------

You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
  # shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.



shfmt errors
'shfmt -i 2' found no issues.

@looztra looztra force-pushed the feat/6/update-platform-pattern branch from 74cd558 to d87b0d2 Compare January 27, 2023 09:13
@looztra looztra merged commit 04de6fa into master Jan 27, 2023
@looztra looztra deleted the feat/6/update-platform-pattern branch January 27, 2023 09:15
libfitz pushed a commit to libfitz/asdf-k9s that referenced this pull request Feb 5, 2023
Reverts some of the changes in looztra#25
libfitz pushed a commit to libfitz/asdf-k9s that referenced this pull request Feb 5, 2023
Reverts some of the changes made in looztra#25
libfitz pushed a commit to libfitz/asdf-k9s that referenced this pull request Feb 5, 2023
Reverts some of the changes made in looztra#25
looztra pushed a commit that referenced this pull request Jun 1, 2023
Reverts some of the changes made in #25

Co-authored-by: affectiosus <affectiosus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant