Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arm64 behavior in 0.27.0+ #28

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Fix arm64 behavior in 0.27.0+ #28

merged 1 commit into from
Jun 1, 2023

Conversation

libfitz
Copy link
Contributor

@libfitz libfitz commented Feb 5, 2023

Reverts some of the changes made in #25.
Should fix #26.

BEGIN_COMMIT_OVERRIDE
fix: make Darwin/arm64 works
END_COMMIT_OVERRIDE

Reverts some of the changes made in looztra#25
Copy link

@canterberry canterberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. I'm not familiar enough with the install script here to have 100% confidence it doesn't break anything, but the changeset does involve the exact problem I'm seeing when managing k9s 0.27.0+, where the release naming conventions have changed from x86_64 to amd64.

@canterberry
Copy link

canterberry commented Feb 6, 2023

For reference, here's the breaking k9s PR: derailed/k9s#1910
This PR was incorporated into the v0.27.0 release.

@libfitz
Copy link
Contributor Author

libfitz commented Feb 20, 2023

@looztra can this be merged please?

@looztra
Copy link
Owner

looztra commented Jun 1, 2023

I am so late on this one.

@looztra looztra merged commit 2b3af87 into looztra:master Jun 1, 2023
Copy link

Hey dear contributors ! 👋🏼
We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Error details:

No release type found in pull request title "Fix arm64 behavior in 0.27.0+". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The latest script installs 0.27.0 amd64 version on Mac M1
3 participants