Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tab Completion (closes #28) #30

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions adventurelib.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,35 @@ def _match_context(context, active_context):
)


class TabCompleter(object):
"""Class, used if `readline` is available for Tab/Auto Comlpetion"""
def __init__(self, commands):
self.commands = commands

def complete(self, text, state):
space = re.compile('.*\\s+$', re.M)
"Generic readline completion entry point."
buffer = readline.get_line_buffer()
line = readline.get_line_buffer().split()
# show all commands
if not line:
return [c + ' ' for c in self.commands][state]
# account for last argument ending in a space
if space.match(buffer):
line.append('')
# resolve command to the implementation function
cmd = line[0].strip()
if cmd in self.commands:
impl = getattr(self, 'complete_%s' % cmd)
args = line[1:]
if args:
return (impl(args) + [None])[state]
return [cmd + ' '][state]
results = [c + ' ' for c in self.commands if c.startswith(cmd)] \
+ [None]
return results[state]
Comment on lines +123 to +144
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All thanks to this thread.



class InvalidCommand(Exception):
"""A command is not defined correctly."""

Expand Down Expand Up @@ -523,6 +552,17 @@ def start(help=True):
qmark.orig_pattern = '?'
commands.insert(0, (Pattern('help'), help, {}))
commands.insert(0, (qmark, help, {}))
try:
_commands = []
for pattern, func, kwargs in _available_commands():
_commands.append(pattern.prefix[0])
_commands = list(set(_commands))
completer = TabCompleter(_commands)
readline.set_completer_delims(' \t\n;')
readline.parse_and_bind("tab: complete")
readline.set_completer(completer.complete)
Comment on lines +652 to +654
Copy link
Author

@naryal2580 naryal2580 Oct 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, too possible by me because of this.

except NameError:
pass
while True:
try:
cmd = input(prompt()).strip()
Expand Down