Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EM-HTTP SSL patch duplication #1201

Closed
ayanko opened this issue Nov 6, 2020 · 1 comment · Fixed by #1202
Closed

EM-HTTP SSL patch duplication #1201

ayanko opened this issue Nov 6, 2020 · 1 comment · Fixed by #1202
Labels
good first issue help wanted

Comments

@ayanko
Copy link
Contributor

ayanko commented Nov 6, 2020 •
edited
Loading

This one is already merged igrigorik/em-http-request#340

https://github.com/igrigorik/em-http-request/blob/v1.1.6/lib/em-http/http_connection.rb#L41

So instead of

require 'faraday/adapter/em_http_ssl_patch'

in

  • lib/faraday/adapter/em_http.rb
  • lib/faraday/adapter/em_synchrony.rb

change to

if EventMachine::HttpRequest::VERSION < '1.1.6'
  require 'faraday/adapter/em_http_ssl_patch'
end

Or remove patch completely...
@kylekeesling
Copy link
Contributor

Happy to take a crack at it! Will submit a PR shortly.

@kylekeesling kylekeesling mentioned this issue Nov 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove EM-HTTP SSL patch duplication
3 participants
@olleolleolle @ayanko @kylekeesling