Merge TLS verification patch from Faraday #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #339, CVE-2020-13482 Credit to Mislav Marohnić for original implementation, merged from Faraday.
|
LGTM |
aharbick
reviewed
Jun 14, 2020
|
|
||
| def ssl_handshake_completed | ||
| unless verify_peer? | ||
| warn "[WARNING; em-http-request] TLS hostname validation is disabled (use 'tls: {verify_peer: true}'), see" + |
There was a problem hiding this comment.
Could this be conditional? If a caller explicitly doesn't want to verify_peer and they do
EventMachine::HttpRequest.new(url, opts.merge({tls: {verify_peer: false}})
It seems unnecessary kick this warning out...
There was a problem hiding this comment.
Yeah, that's reasonable. Willing to put together a quick patch? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #339, CVE-2020-13482
Credit to Mislav Marohnić for original implementation, merged from Faraday.