Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fix #1109

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Documentation fix #1109

merged 1 commit into from
Jan 8, 2020

Conversation

iMacTia
Copy link
Member

@iMacTia iMacTia commented Jan 8, 2020

Description

Mentions in the documentation that the Retry middleware handles the Retry-After header.
Fixes #773 (comment)

@iMacTia iMacTia mentioned this pull request Jan 8, 2020
2 tasks
@iMacTia iMacTia merged commit 8a43a47 into master Jan 8, 2020
@iMacTia iMacTia deleted the retry-after-doc branch January 8, 2020 20:20
@vvo
Copy link
Contributor

vvo commented Jan 9, 2020

Hi @iMacTia I believe if you want retry-after to be honored, the minimum configuration is: faraday.request :retry, retry_statuses: [429] do you confirm? If so I think the doc should provide that, Ill open a PR

vvo added a commit to vvo/faraday that referenced this pull request Jan 9, 2020
olleolleolle added a commit that referenced this pull request Jan 9, 2020
* docs(retry): precise usage of retry-after

Fixes #1109 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants