Fully qualify constants to be checked #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This relates to the issue #974 - This tries to make the single consistent fix mentioned in that ticket
olleolleolle
force-pushed
the
fully-qualified-constants-lookup
branch
from
26e8ecd
to
f799b53
Compare
|
@olleolleolle you can now pull latest from |
|
@iMacTia There - squash-ready! |
iMacTia
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to constants in ways that their names never collide.
Description
See #974 for details.
This quote lists the route this PR took:
In order to see if tests are green - this PR disables rack adapters tests which suffer #1119