-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add adapter for the HTTP.rb gem #591
Conversation
The gem link: https://rubygems.org/gems/http You can initialize the adapter with any of the options that the gem allows Examples Faraday.new do |faraday| faraday.adapter :http, :keep_alive_timeout => 10 end
Since there is now a new adapter, it means that is going to add more code, and some parts of that code are not going to be tested when the SSL options is not set. That means that is going to be less coverage during non SSL tests.
Fallback for instace vars syntax.
@jhbabon I can see the PR on http was merged, can you update your branch to make tests passing?
@mislav, @technoweenie, this would be a new adapter so is probably better if you review it. |
I think this would work better as a I realize that Faraday depends on plenty of gems today. Some plans in a completely rewritten Faraday 1.0 and separate Hurley gem included supporting only the core |
Hi @jhbabon I just want to update you on the situation. I appreciate your patience. In the meantime, you can update your branch with the latest |
Hi @iMacTia! Thanks for the all the explanations. I think is better to close this PR because right now I can't confirm that this adapter has the same or more of the features other adapters have, specially the streaming part. Also, moving this to a separate gem once the version Thanks for your patience. |
Thank you for your understanding! |
The gem link: https://rubygems.org/gems/http
You can initialize the adapter with any of the options that the gem allows:
I know there is a PR trying to do something similar (#564) but is kind of stuck and is using and old version of the
http
gem, so I decided to try my adapter. Feel free to close this PR if you want to push the other one and sorry if is bothering someone.About the stack trace in the specs, I opened a PR for the
http
gem as well to see if it can be fixed. I think there is nothing we can do in the Faraday side. This is the PR: httprb/http#353