Returns the http response when giving up on retrying by status #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiokr
force-pushed
the
bugfix/retry-status
branch
from
a87e5c5
to
5931f71
Compare
fabiokr
changed the title
rubemz
approved these changes
Mar 23, 2018
boone
approved these changes
Mar 23, 2018
iMacTia
approved these changes
Mar 24, 2018
|
Thank you very much @fabiokr for spotting this issue and fixing it so quickly 😃 |
|
@iMacTia Yep, tested it and it works as expected 😄 |
|
@fabiokr Faraday 0.15.0 was released last week 👍 |
|
@iMacTia Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#773 implemented retry by status, but, when the middleware gives up on retrying, we just get nil back as the response. This PR fixes that by returning the last available response the middleware got.
https://github.com/lostisland/faraday/pull/773/files#r176779382