Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually show a and k on property docs #77

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Manually show a and k on property docs #77

merged 3 commits into from
Aug 6, 2024

Conversation

mbasaglia
Copy link
Member

@mbasaglia mbasaglia commented Aug 6, 2024 •
edited
Loading

Solves #35

This does a couple things:

  • Expands the schema_object block processor to include custom <tr elements into the table
  • Adds title/description to gradient property k
  • Adds relevant k and a rows on the property docs page

@mbasaglia mbasaglia requested review from fmalita, b-wils and Aidosmf August 6, 2024 08:08
@mbasaglia mbasaglia marked this pull request as draft August 6, 2024 08:11
@mbasaglia
Copy link
Member Author

The gradient stuff is more complicated than I thought...

@mbasaglia mbasaglia marked this pull request as ready for review August 6, 2024 08:15
@mbasaglia
Copy link
Member Author

This is how it looks like for gradients:

Screenshot_20240806_101633

@mbasaglia mbasaglia merged commit b4d561b into lottie:main Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kudanai kudanai kudanai approved these changes

@fmalita fmalita fmalita approved these changes

@b-wils b-wils b-wils approved these changes

@Aidosmf Aidosmf Awaiting requested review from Aidosmf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbasaglia @kudanai @fmalita @b-wils