-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal text cols adjusts to terminal container. #285
Conversation
The real terminal is in the backend using "node-pty". It needs to update the the column in the backend too. |
I will have a look into that. |
I have added:
|
Thanks, but I believe that a lot of code changes are just format changes, not logic changes, which makes it harder for me to review your code. Please keep them unchanged. And should use project's eslint only, these commands may help:
|
I went back through using GitHub diff split view to remove any unnecessary changes, sorry about that. |
package.json
Outdated
@@ -71,8 +69,10 @@ | |||
"@typescript-eslint/eslint-plugin": "~6.8.0", | |||
"@typescript-eslint/parser": "~6.8.0", | |||
"@vitejs/plugin-vue": "~4.5.2", | |||
"@xterm/addon-fit": "0.9.0-beta.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason to use the specific beta version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I choose @xterm/addon-fit package over xterm-addon-fit as it is the new addon format see xterm README as of xterm v3.14.0.
The version for it is 0.9.0-beta.17 no full release yet. Though it is a drop in replacement for the other one which is at v0.8.0 or has a beta release of 0.9.0-beta.37.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, but since 0.9.0-beta.17
requires @xterm/xterm
instead of xterm
, I have to change this along with this pr.
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md
Tick the checkbox if you understand [x]:
Description
Fixes #(223)
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
My code needed automated testing. I have added them (this is optional task)Screenshots
Before Changes
After Changes