-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Only adding folders to stack with a compose file. #299
Conversation
It checks if the folder in the stacks has any of the following files |
* @param {string} filename - The name of the directory to check for the compose file. | ||
* @returns {Promise<boolean>} A promise that resolves to a boolean indicating whether any compose file exists. | ||
*/ | ||
static async composeFileExists(stacksDir : string, filename : string) : Promise<boolean> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel it is a bit over used await and promise here. I try to rewrite it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No kidding, that is definitely a weak point for me hahaha
Actually I was thinking using something like I think it is ok at this moment. |
I think it would be a good idea to also rely on the gitignore, but the gitignore often doesn't hide some main folders (like the .git folder) so if you are going this approach you would probably want something more custom. |
https://github.com/louislam/dockge/blob/master/CONTRIBUTING.md
Tick the checkbox if you understand [x]:
Description
Fixes #183
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)
Before
After