Fix: Schedule next beat at the start of a beat

louislam · Jul 18, 2023 · 5b23d33 · 5b23d33
1 parent 66cfbd0
commit 5b23d33
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/server/model/monitor.js b/server/model/monitor.js
@@ -266,6 +266,14 @@ class Monitor extends BeanModel {
                 }
             }
 
+            // Schedule next beat
+            if (! this.isStop) {
+                log.debug("monitor", `[${this.name}] SetTimeout for next check.`);
+                this.heartbeatInterval = setTimeout(safeBeat, beatInterval * 1000);
+            } else {
+                log.info("monitor", `[${this.name}] isStop = true, no next check.`);
+            }
+
             // Expose here for prometheus update
             // undefined if not https
             let tlsInfo = undefined;
@@ -571,6 +579,7 @@ class Monitor extends BeanModel {
                             // No need to insert successful heartbeat for push type, so end here
                             retries = 0;
                             log.debug("monitor", `[${this.name}] timeout = ${timeout}`);
+                            clearTimeout(this.heartbeatInterval);
                             this.heartbeatInterval = setTimeout(safeBeat, timeout);
                             return;
                         }
@@ -910,14 +919,6 @@ class Monitor extends BeanModel {
             this.prometheus?.update(bean, tlsInfo);
 
             previousBeat = bean;
-
-            if (! this.isStop) {
-                log.debug("monitor", `[${this.name}] SetTimeout for next check.`);
-                this.heartbeatInterval = setTimeout(safeBeat, beatInterval * 1000);
-            } else {
-                log.info("monitor", `[${this.name}] isStop = true, no next check.`);
-            }
-
         };
 
         /** Get a heartbeat and handle errors */