Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Toast] useToast not called properly in pages/EditMonitor.vue #5323

Closed
1 task done
Dorence opened this issue Nov 7, 2024 · 2 comments
Closed
1 task done

[Toast] useToast not called properly in pages/EditMonitor.vue #5323

Dorence opened this issue Nov 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Dorence
Copy link
Contributor

Dorence commented Nov 7, 2024

πŸ“‘ I have found these related issues/pull requests

No similar bugs have been reported

πŸ›‘οΈ Security Policy

Description

Saving the monitor config not working in monitor editing page.

Look into dev console,

TypeError: Iu.error is not a function
at Proxy.isInputValid (index-qm3xr2Qi.js:579:4928)
at Proxy.submit ...

Changing const toast = useToast; to const toast = useToast(); in src/pages/EditMonitor.vue can fix it.

πŸ‘Ÿ Reproduction steps

  • Set any custom request body to a HTTP monitor
  • Save (success)
  • Change HTTP to TCP Port
  • Save (failed, there should no be any header)

πŸ‘€ Expected behavior

A toast shows to tell what is going wrong. And user can edit continuing.

πŸ˜“ Actual Behavior

No toast shown and unable to edit.

🐻 Uptime-Kuma Version

2.0.0-beta.0

πŸ’» Operating System and Arch

Ubuntu 2404 x64

🌐 Browser

Microsoft Edge 124.0.2478.80 x64

πŸ–₯️ Deployment Environment

  • Runtime: nodejs 18
  • Database: default sqlite
  • Filesystem used to store the database on: ext4
  • number of monitors: 20+

πŸ“ Relevant log output

No response

@Dorence Dorence added the bug Something isn't working label Nov 7, 2024
@louislam louislam added this to the 2.0.0-beta.1 milestone Nov 7, 2024
@CommanderStorm
Copy link
Collaborator

Since you already debugged this, would you like this change be credited to you (via an PR)?

@Dorence
Copy link
Contributor Author

Dorence commented Nov 11, 2024

Sure, new PR #5333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants