Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upside down push monitors #1762

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Fix upside down push monitors #1762

merged 1 commit into from
Jun 14, 2022

Conversation

kaysond
Copy link
Contributor

@kaysond kaysond commented Jun 14, 2022

Description

This PR fixes a regression introduced by 1.16.1 (#1428) where upside down push monitors were not handled correctly. (Fixes #1732)

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@kaysond
Copy link
Contributor Author

kaysond commented Jun 14, 2022

@louislam can you please pick this for 1.17.0? Sorry about the regression. I didn't think to test upside down push monitors!

@Apashh
Copy link

Apashh commented Jun 14, 2022

Hey, ty for your job, i have modified this line (since 2-3 hours) in monitor.js and its works ! ;)

@louislam
Copy link
Owner

Thanks, didn't aware of it too.

@louislam louislam merged commit 9b21b86 into louislam:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push Monitor : Return to UP but still DOWN
4 participants