Adding GoAlert Notification

[mhkarimi1383]

Description

Adding GoAlert support

according to Alerting From Generic API and it's handler here

Type of change

Please delete any options that are not relevant.

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update (if other notifications are documented) Full List of Supported Notifications #284

Checklist

• My code follows the style guidelines of this project
• I ran ESLint and other linters for modified files
• I have performed a self-review of my own code and tested it
• I have commented my code, particularly in hard-to-understand areas
  (including JSDoc for methods)
• My changes generate no new warnings
• My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

[mhkarimi1383]

Everything Should be fine my reviews and tests will be finished tomorrow :)

[mhkarimi1383]

Hello again
json content type was not working with GoAlert correctly (with lots of tests)
So, I migrated to form-data
but form-data and axios are not able work great together but new version of axios has internal support for form-data handling, so I upgraded axios package

more info:
axios form-data

[mhkarimi1383]

Since I added upgraded a package and package-lock.json changed I want to know what is the correct version of npm and nodejs just for running npm ci again to solve it.
or someone do it for me.
thanks

[chakflying]

You should be running npm v7+ to use the newer version of the lockfile. The node version should not matter as long as it's 14+.

[mhkarimi1383]

using npm 8.18.0 and node v18.8.0
but CI fails

[k3rnelpan1c-dev]

IIRC Node 14 + NPM 7 (the default NPM version with Node 14 IIRC), does not support lockfiles v2.
The general CI auto-test use a range of Node Version [14..18] but the check-lintersonly runs 14.

Side notes:

• 14 being a prior LTS is still in maintained till May 2023 (https://nodejs.org/en/about/releases/)
• 17, which is also in the auto-test range, should probably be dropped due to it only ever been a "current" release with no further development / maintenance.

[chakflying]

Thanks, I remembered it wrong.

Thing is, CI should still work even with lockfile version mismatch (as it has worked all this time). I think you broke something else when you regenerated that file on MacOS, somehow the linux dependencies are missing. Anyway I think louislam can handle it if this gets merged.

[mhkarimi1383]

Thanks, I remembered it wrong.

Thing is, CI should still work even with lockfile version mismatch (as it has worked all this time). I think you broke something else when you regenerated that file on MacOS, somehow the linux dependencies are missing. Anyway I think louislam can handle it if this gets merged.

I'm on ArchLinux using nvm

[mhkarimi1383]

node --version
v14.6.0

npm --version
6.14.6

What is the ideal version?

[k3rnelpan1c-dev]

okay, took another look, and seems as if the main branch is already using a v2 lock-file. so I am surprised that this hasn't pop up earlier 🤔

Edit:

🤦‍♂️ we where looking at the wrong line (like most regular npm users and the lockfile was just a warning not an error):

npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} > (current: {"os":"linux","arch":"x64"})
npm ERR! notsup Valid OS: darwin
npm ERR! notsup Valid Arch: any
npm ERR! notsup Actual OS: linux
npm ERR! notsup Actual Arch: x64

looks like fsevents@2.3.2 wants the host to be MacOS, yet we on Linux CI and in the container images too.

[mhkarimi1383]

okay, took another look, and seems as if the main branch is already using a v2 lock-file. so I am surprised that this hasn't pop up earlier 🤔

Edit:

🤦‍♂️ we where looking at the wrong line (like most regular npm users and the lockfile was just a warning not an error):

npm ERR! code EBADPLATFORM
npm ERR! notsup Unsupported platform for fsevents@2.3.2: wanted {"os":"darwin","arch":"any"} > (current: {"os":"linux","arch":"x64"})
npm ERR! notsup Valid OS: darwin
npm ERR! notsup Valid Arch: any
npm ERR! notsup Actual OS: linux
npm ERR! notsup Actual Arch: x64

looks like fsevents@2.3.2 wants the host to be MacOS, yet we on Linux CI and in the container images too.

How main branch is working?

[k3rnelpan1c-dev]

I have not the slightest idea, but a couple of pointers that may be worth evaluating if they are the cause:

• flaky CI (given you are on Arch you could try nuking your current downloaded dependency cache and attempt build to see if that theory applies)
• some funky dependency change within a sub-dependency (if any of the dependencies uses version ranges or similar)

(given that CI passed before regenerating the lockfile it can be either)

Please note that I am merely a CI enthusiast who likes this project and stumbled over your PR. I have no power here, besides trying to help debugging 🤔

[mhkarimi1383]

fixed by switching to node v16