Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make monitor start() and stop() async #2830

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

spali
Copy link
Contributor

@spali spali commented Feb 23, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@chakflying
Copy link
Collaborator

Tested rebased on master seems to work fine. Should be no reason blocking this to merge? @louislam

@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Jan 30, 2024
@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Jan 30, 2024

@louislam FYI: I put this in v2.1 as I don't see any blocking change and think this can be merged as is from my side. If you disgree, please remove it ^^

@CommanderStorm
Copy link
Collaborator

Thanks for the change.
All changes in this PR are small and uncontroversial (I agree with @spali on this one that refactoring the logic to be less blocking should be done in another PR)
⇒ merging with junior maintainer approval.

@CommanderStorm CommanderStorm merged commit 2a3a220 into louislam:master Mar 9, 2024
17 checks passed
@CommanderStorm CommanderStorm modified the milestones: 2.1.0, 2.0.0 Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants