fix: keep notification and heartbeat records when import backup with … #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this PR has any problem there?,should I cancel it? |
|
What you implemented is not only a fix (which there was already a PR open), but also a breaking change to the behavior of overwrite mode without previous discussion. |
Saibamen
reviewed
Jul 20, 2023
| monitorsIdList = monitorsIdList.map((item) => { | ||
| return item.id; | ||
| }); | ||
| log.info("manage", "Import Backup with 'overwrite mode. now remove the monitors which is not in backup json'"); |
There was a problem hiding this comment.
Suggested change
| log.info("manage", "Import Backup with 'overwrite mode. now remove the monitors which is not in backup json'"); | |
| log.info("manage", "Import Backup with 'overwrite mode'. Now remove the monitors which is not in backup JSON'"); |
| monitorsIdList.splice(idx, 1); | ||
| } | ||
| } | ||
| log.info("manage", `Need OverWrite Monitors Id List:[${needOverWriteMonitorsIdList}],Length:${needOverWriteMonitorsIdList.length}`); |
There was a problem hiding this comment.
Suggested change
| log.info("manage", `Need OverWrite Monitors Id List:[${needOverWriteMonitorsIdList}],Length:${needOverWriteMonitorsIdList.length}`); | |
| log.info("manage", `Need OverWrite Monitors Id List: [${needOverWriteMonitorsIdList}], Length:${needOverWriteMonitorsIdList.length}`); |
| // delete old same monitor item with expired id | ||
| await R.exec("DELETE FROM monitor where id= ? ", monitorListData[i].id); | ||
| } else { | ||
| log.info("manage", `[BackUp OverWrite Mode] Find new monitor Join - name:${monitorListData[i].name}`); |
There was a problem hiding this comment.
Suggested change
| log.info("manage", `[BackUp OverWrite Mode] Find new monitor Join - name:${monitorListData[i].name}`); | |
| log.info("manage", `[BackUp OverWrite Mode] Find new monitor Join - name: ${monitorListData[i].name}`); |
Merged
|
Obsolete as the backup feature has been dropped in #3892. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…overwrite mode
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #677
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.