-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flashduty notification #3475
Conversation
Could you also add a screenshot of the notification provider working? ^^ |
refactor code; add en zh-hk zh-tw lang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space.
Because of the network, may I use the screenshot hosted by imgur? (Currently, most of Flashduty users are in China, so the screenshot has some Chinese words.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
about the screenshots: Could you attach a screenshot showing how the Test
button looks when pressed?
(I am a bit concearned that specifing it as a url
=> using it as a resource
in postNotification
might not work)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think including zh-HK
and zh-TW
translation is unnecessary. Otherwise looks okay.
@CommanderStorm is it ready to merge this PR ? or anything to improve ? |
As indicated by my aproval-review: |
thank you for your reply. I will wait louis's feedback. |
Same thought, just need to change zh-CN.json, as the others are using Traditional Chinese. Other code changes look good to me. |
@chakflying @louislam ok, I revert the changes in zh-HK and zh-TW and fix the conflicts in en.json |
Tick the checkbox if you understand [x]:
Description
Add notification provider of Flashduty (which is a Saas monitor noise reduction platform in China.)
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots