-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a 'default locale' and locale switcher on status pages #3523
base: master
Are you sure you want to change the base?
Allow a 'default locale' and locale switcher on status pages #3523
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
re-reading the contributing guide I seem to have overlooked the 'create an empty pull request as to allow for discussion first'. My apologies, feel free to still discuss these features as if they hadn't been written :) |
This comment was marked as resolved.
This comment was marked as resolved.
Hi @louislam , Really sorry to bother you. I have altered my migration into a knex migration, but it seems that the auto-test does not correctly bootstrap the base migrations for the project. Am I doing something wrong, or should there be a fix introduced into the auto-tester? |
I am re-implementing new auto-test due to this issue. You could ignore them at this moment if you tested successfully in your local environment. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@wampiedriessen |
Hey guys, This PR was waiting for the introduction of v2. I had tested it waay before, using the devcontainer and a browser. I might find the time somewhere in the future to revisit these changes and fix things |
Co-authored-by: Matthew Nickson <mnickson@sidingsmedia.com>
aff6a5b
to
b755800
Compare
Hi all, I've found the time to polish my MR. I've adressed the bug found bij louislam, the localeSelector now shows/hides based on the setting in the config for that statuspage. I could not reproduce the bug that - in private mode - the language is not set to the default for that statuspage. Steps:
|
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #2196, fixes #1643, fixes #3487
I use UptimeKuma myself, and found myself in need of a 'default locale' selector for the status page.
Since I thought: we do not want to force a language upon anybody, i also built an optional 'locale selector' in the top-right corner of the statuspage.
If somebody (logged in user) already has a known locale (which is set in the localstore) that language is used.
If the page has a default locale, that language is set temporarily (only for that page)
If the statuspage has a language selector and it is used, that language is saved into the localstore (I presume a user wants the same language on all status-pages of the website)
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)