Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore TLS/SSL error for Redis #3878

Merged
merged 13 commits into from
May 19, 2024

Conversation

HdroguettA
Copy link
Contributor

@HdroguettA HdroguettA commented Oct 11, 2023

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #3871

Type of change

  • User interface (UI)
  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

@louislam louislam added this to the 2.0.0 milestone Oct 12, 2023
@louislam louislam modified the milestones: 2.0.0, 2.1.0 Nov 23, 2023
@louislam louislam added the question Further information is requested label Nov 23, 2023
@louislam
Copy link
Owner

It did not pass the linter.

@chakflying chakflying added the area:monitor Everything related to monitors label Dec 2, 2023
CommanderStorm

This comment was marked as resolved.

@louislam louislam removed the question Further information is requested label Dec 10, 2023
@CommanderStorm CommanderStorm added help wanted May need your help to test or answer pr:needs review this PR needs a review by maintainers or other community members labels May 19, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

All changes in this PR are small and uncontroversial
⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm modified the milestones: 2.1.0, 2.0.0 May 19, 2024
@CommanderStorm CommanderStorm removed the pr:needs review this PR needs a review by maintainers or other community members label May 19, 2024
@CommanderStorm CommanderStorm merged commit daca38a into louislam:master May 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors help wanted May need your help to test or answer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[redis] Ignore TLS/SSL error
4 participants