-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slack] restructure alert actions, add 'visit site' button #3886
[Slack] restructure alert actions, add 'visit site' button #3886
Conversation
(sorry for providing everything as separate reviews, I thought I was in a review session) Mostly, this looks good, except for a few stylistic things. |
This comment was marked as resolved.
This comment was marked as resolved.
Fixed casing Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Nelson Chan <3271800+chakflying@users.noreply.github.com>
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
Thanks for the change to the notification provider! All changes in this PR are small and uncontroversial |
I see this is merged, do we know when it will be released? |
We have written down what needs to happen before v2.0.0-beta1 can happen in #4500 |
Tick the checkbox if you understand [x]:
Description
Fixes #3351: adds the monitor url as a button to the slack message. Also, restructured the code which adds the "Visit Uptime Kuma" button to be more readable and modular.
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)