Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom in on real browser screenshot #3925

Merged
merged 9 commits into from
Nov 23, 2023
Merged

Zoom in on real browser screenshot #3925

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
775f37a
Screenshot in modal
adamhancock Oct 21, 2023
5e0d85f
Merge branch 'master' into screenshot-in-modal
adamhancock Oct 21, 2023
84e84d5
Merge branch 'master' into screenshot-in-modal
adamhancock Oct 21, 2023
244341f
Update src/components/ScreenshotDialog.vue
adamhancock Oct 21, 2023
14a4b44
Update src/pages/Details.vue
adamhancock Oct 21, 2023
22addbe
Added title
adamhancock Oct 21, 2023
ad54732
Update ScreenshotDialog.vue
adamhancock Oct 21, 2023
adf7c03
Add translations
adamhancock Oct 22, 2023
2b3c719
Merge branch 'master' into screenshot-in-modal
adamhancock Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/ScreenshotDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,13 @@
<div class="modal-dialog modal-xl modal-dialog-centered">
<div class="modal-content">
<div class="modal-header">
<h5 id="exampleModalLabel" class="modal-title">
adamhancock marked this conversation as resolved.
Show resolved Hide resolved
{{ $t("Browser Screenshot") }}
adamhancock marked this conversation as resolved.
Show resolved Hide resolved
</h5>
<button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close" />
</div>
<div class="modal-body"></div>
adamhancock marked this conversation as resolved.
Show resolved Hide resolved
<img :src="imageURL">
<img :src="imageURL" alt="screenshot of the website">
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/Details.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
<div v-if="monitor.type === 'real-browser'" class="shadow-box">
<div class="row">
<div class="col-md-6 zoom-cursor">
<img :src="screenshotURL" style="width: 100%;" alt @click="showScreenshotDialog">
<img :src="screenshotURL" style="width: 100%;" alt="screenshot of the website" @click="showScreenshotDialog">
</div>
<ScreenshotDialog ref="screenshotDialog" :imageURL="screenshotURL" />
</div>
Expand Down
Loading