Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google chat cards #3928

Merged
merged 7 commits into from
Mar 20, 2024
Merged

Conversation

elliotmatson
Copy link
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Adds card-based messages to Google Chat for more streamlined notifications

Type of change

Please delete any options that are not relevant.

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots

image

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good to go.
I have left some minor comments.

Could you add a screenshot of the before state?

server/notification-providers/google-chat.js Outdated Show resolved Hide resolved
server/notification-providers/google-chat.js Outdated Show resolved Hide resolved
server/notification-providers/google-chat.js Outdated Show resolved Hide resolved
elliotmatson and others added 4 commits October 22, 2023 15:18
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
@elliotmatson
Copy link
Contributor Author

Thanks! Good catches!

Here's before:
image

@louislam louislam added this to the 2.2.0 milestone Nov 23, 2023
@chakflying chakflying added the area:notifications Everything related to notifications label Dec 2, 2023
@CommanderStorm CommanderStorm modified the milestones: 2.2.0, 2.0.0 Mar 20, 2024
@CommanderStorm
Copy link
Collaborator

Thanks for the enhancement!

All changes in this PR are small and uncontroversial
⇒ merging with junior maintainer approval (despite this being in a future merge-slot)

@CommanderStorm CommanderStorm merged commit 5bc68fe into louislam:master Mar 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants