-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SevenIO Notification Provider #4219
Conversation
Reminder to myself: after this is closed, remove codespace: https://github.com/codespaces/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, this is a really well written notification provider 👍🏻
I have left a few things I noticed.
Could you add screenshots of the provider working using the following skip this part of testing (and cost as sms likely costs) for us:
DOWN
/UP
Testing
Cert-Expiry
(see https://badssl.com/)
<template> | ||
<div class="mb-3"> | ||
<label for="sevenio-api-key" class="form-label">{{ $t("apiKeySevenIO") }}</label> | ||
<input id="sevenio-api-key" v-model="$parent.notification.sevenioApiKey" type="text" class="form-control" required autocomplete="false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use HiddenInput
for sensitive fields instead ^^
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Allready tested it before opening pr: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new notification provider!
All changes in this PR are as discussed in the contribution guide
=> moving this from v2.1 to v2.0
Merging despite #4219 (comment) being open by resolving the remaining issues myself
<template> | ||
<div class="mb-3"> | ||
<label for="sevenio-api-key" class="form-label">{{ $t("apiKeySevenIO") }}</label> | ||
<input id="sevenio-api-key" v-model="$parent.notification.sevenioApiKey" type="text" class="form-control" required autocomplete="false"> |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…her notification providers
Description
Added SevenIO notification provider
Resolves #3976
Type of change
Checklist