-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the color of delete button in dashboard from red to grey #4307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted by nelson in #4290 (comment) or by me in #4290 (comment):
Changing this to be gray does not solve what we want to convey.
Please either
- hide it in an overflow menu
- or make this button into a secondary button in style only, not color (prefered by me, idk about @chakflying / @louislam )
Please also include a screenshot of the change you did.
What's the point of changing it to grey in the first place? Red means danger and it is correct color for delete |
@CommanderStorm, is this how you wanted? |
yes this looks good |
Thanks for the opportunity team :) |
@CommanderStorm Why did we remove the red? "red to grey as per the requirement" - I must be missing something; what requirement? Thanks for your time. |
@ZachFabin Please see #4290 why we did the change. |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Changed the color of the delete button in dashboard from red to grey as per the requirement. Just replaced class name from 'btn-danger' to 'btn-secondary' to achieve the changes.
@louislam
Type of change
Checklist
Screenshots