Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encodeBase64 for empty password or user in HTTP Basic Authentication #4326

Merged
merged 4 commits into from
Jan 6, 2024
Merged

Fix encodeBase64 for empty password or user in HTTP Basic Authentication #4326

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51d8ccf
Fix encodeBase64 for empty password or user
Saibamen Jan 5, 2024
dbf4929
Simplify `encodeBase64`
Saibamen Jan 5, 2024
9dff412
Fix ESLint
Saibamen Jan 5, 2024
ce2c61f
Update JSDoc
Saibamen Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion server/model/monitor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,12 @@ class Monitor extends BeanModel {
/**
* Encode user and password to Base64 encoding
* for HTTP "basic" auth, as per RFC-7617
* @param {string|null} user - The username (nullable if not changed by a user)
* @param {string|null} pass - The password (nullable if not changed by a user)
* @returns {string}
*/
encodeBase64(user, pass) {
return Buffer.from(user + ":" + pass).toString("base64");
Saibamen marked this conversation as resolved.
Show resolved Hide resolved
return Buffer.from(`${user || ""}:${pass || ""}`).toString("base64");
}

/**
Expand Down